Open
Conversation
- added Docker Compose setup with example environment file, Compose yaml, and entrypoint script for dynamic Nginx config generation - updated Dockerfile to include the config generator - revised `README.md` with new setup and configuration instructions - flexible proxy integration for Pi-hole, Deluge, and Jellyfin via environment variables
Updated README and compose.env.example to clarify that PIHOLE_HOST_HEADER, DELUGE_HOST_HEADER, and JELLYFIN_HOST_HEADER can be left blank to fall back to Nginx's $host variable automatically.
Changed ENABLE_*_PROXY variables for Pi-hole, Deluge, and Jellyfin to default to false in compose.env.example and compose.yaml. Updated README to clarify that upstream proxy blocks are disabled by default for easier initial setup.
Updated documentation and environment examples to clarify that PIHOLE_PROXY_TARGET is required when ENABLE_PIHOLE_PROXY is true. Modified entrypoint script to skip Pi-hole proxy block if PIHOLE_PROXY_TARGET is empty, preventing misconfiguration. Also reordered Deluge proxy block generation for consistency.
|
I would recommend adding a build task to github and just have it host the image(s). This way people dont have to build their own and mess around with any of the repo cloning. Instead it is all pre-built and all we as users would do is pull the image and give it a volume to store data. |
|
@mult1v4c This pull request was put in several months ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR contains:
compose.env.example,compose.yaml), and entrypoint script for dynamic Nginx config generationDockerfileto include the config generatorREADME.mdwith new setup and configuration instructionsp.s. thanks for the awesome dashboard (: