FEAT(client,avatars): Add avatar icons to user view#6856
Open
GeneralUser01 wants to merge 6 commits intomumble-voip:masterfrom
Open
FEAT(client,avatars): Add avatar icons to user view#6856GeneralUser01 wants to merge 6 commits intomumble-voip:masterfrom
GeneralUser01 wants to merge 6 commits intomumble-voip:masterfrom
Conversation
Krzmbrzl
requested changes
Jun 27, 2025
Member
Krzmbrzl
left a comment
Krzmbrzl
left a comment
There was a problem hiding this comment.
The hardcoded alignmntsaddings also seem like they could cause trouble for users with different screen resolutions.
Member
|
Could you perhaps add a screenshot to the PR description? That makes it easier to figure out what exactly the end result is :) |
GeneralUser01
force-pushed
the
avatar-icons
branch
from
d128074 to
f8a97d2
Compare
The UI was here changed to use the avatar as user icon in the user view instead of only showing it in a tooltip when a user is hovered, in a comment on them and in the overlay. This enables one to easier distinguish users as well as getting more use of each user's avatar in a way that would be expected.
Somehow the user view was only updated when setting an avatar and not when removing it. Since `update()` on the widget doesn't work here with `UserDelegate` this change instead refreshes it by adjusting the foreground color back and fourth once. This is done unnoticeably quickly and only adjusts the color by the smallest amount. Furthermore, this would only require a couple repaints unlike a resize which would also require reflows (recalculating the layout).
Because at least the colors of the custom avatar talk indicator should come from the theme, this change makes SVG icons for it in the theme, with there being one for each talk status just as for the default avatar talk indicator except for when passive. The new icons have a transparent background and are overlaid the user-provided image when the user's talk status is not passive.
…as a custom avatar
…s this?" message on users
GeneralUser01
force-pushed
the
avatar-icons
branch
from
f8a97d2 to
bdc97a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI was here changed to use the avatar (if the user has one) as user icon in the user view instead of only showing it in a tooltip when a user is hovered and in the overlay.
This enables one to easier distinguish users as well as getting more use of each user's avatar in a way that would be expected. Below is an example showing the differences.
Without avatar:
With avatar:
The "What's this?" message on users was also extended to include the custom avatar talk indicator as shown here:
Checks