BUILD(client): Raise macOS deployment target to 14

[nicholas-lonsinger]

Summary

• Raise CMAKE_OSX_DEPLOYMENT_TARGET from 10.15 to 14 (Sonoma), removing compatibility shims and dead code for macOS 10.5–10.14
• Disable the macOS overlay for all macOS builds — it relies on mach_override (no ARM support) and deprecated APIs like AuthorizationExecuteWithPrivileges
• Replace deprecated NSSpeechSynthesizer (AppKit) with AVSpeechSynthesizer (AVFoundation), eliminating the manual utterance queue and delegate chain
• Remove all dead macOS overlay code, files, scripts, and the mach-override submodule left behind after disabling the overlay
• Clean up CoreAudio.mm deprecation pragma that is no longer needed after kAudioObjectPropertyElementMaster migration

Changes by commit

1. 5adac2d — BUILD(client): Raise macOS deployment target to 14 and disable overlay

   • kAudioObjectPropertyElementMaster → kAudioObjectPropertyElementMain
   • Deprecated AudioDeviceGetProperty → AudioObjectGetPropertyData
   • Remove @available() guards for macOS 10.12/10.14
   • NSAutoreleasePool → @autoreleasepool blocks
   • Remove Carbon API fallback code, respondsToSelector: checks for long-available APIs
   • Remove macOS overlay build targets and dependencies (ScriptingBridge, Security, xar)
   • Remove USE_MAC_UNIVERSAL preprocessor guard in VersionCheck

2. 2231a65 — REFAC(client): Replace deprecated NSSpeechSynthesizer with AVSpeechSynthesizer

   • AVSpeechSynthesizer has built-in utterance queuing, so the manual NSMutableArray queue and delegate chain are no longer needed

3. 5e7f82e — MAINT(client): Remove dead macOS overlay code, files, and submodule

   • Remove 3rdparty/mach-override-src submodule and mach-override-build wrapper
   • Remove overlay scripts from macx/scripts/ and macx/osax/ directory
   • Delete overlay_gl macOS files and dead Overlay_macx.mm
   • Remove USE_OVERLAY blocks and dead forwardEvent slot from GlobalShortcut_macx.mm/.h
   • Remove Q_OS_MAC blocks from OverlayClient.cpp/.h and OverlayUserGroup.cpp
   • Remove macOS overlay UI string from GlobalShortcut.cpp/.ui and translations
   • Clean up overlay style default and font #ifdef in Settings.cpp
   • Remove dead deprecation pragma from CoreAudio.mm
   • Delete unused g15helper_macx.c

Test plan

• Verify the client builds on macOS 14+ with cmake -B build -Dserver=OFF -Dtests=ON && cmake --build build
• Verify text-to-speech works with the new AVSpeechSynthesizer backend
• Verify global shortcuts still function correctly
• Confirm overlay remains functional on Windows/Linux/FreeBSD (no changes to those platforms)

🤖 Generated with Claude Code

[coderabbitai]

Walkthrough

This PR modernizes macOS support by raising the deployment target to macOS 14 and removing legacy compatibility code. It replaces deprecated Core Audio APIs with updated equivalents, eliminates platform-specific overlay injection mechanisms, and refactors text-to-speech implementation from NSSpeechSynthesizer to AVSpeechSynthesizer. The PR removes macOS-specific compilation guards throughout the codebase, making several code paths unconditional. The overlay implementation for macOS is completely removed, with overlay support now using the Unix implementation instead. The changes simplify the codebase by dropping support for older macOS versions and deprecated frameworks.

Possibly related PRs

• mumble#7060: Modifies CMake overlay inclusion and guard logic around ARM/Apple platforms, sharing similar build-configuration changes for overlay handling.

Suggested reviewers

• Krzmbrzl

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: raising the macOS deployment target to version 14. It is concise and clearly reflects the primary objective of the PR.
Description check	✅ Passed	PR description is comprehensive and well-structured with clear summary, organized changes by commit, and test plan, though one test item remains unchecked.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/mumble/CMakeLists.txt (1)

1035-1041: ⚠️ Potential issue | 🟠 Major

AVFoundation is only linked when coreaudio is enabled, but TextToSpeech_macx.mm depends on it unconditionally.

TextToSpeech_macx.mm is added unconditionally for Apple builds (line 794) and imports <AVFoundation/AVFoundation.h>. However, AVFoundation is currently linked only at line 1039 within the if(coreaudio) block. If a user disables CoreAudio (-Dcoreaudio=OFF), the build will fail with a linker error.

Move the AVFoundation framework linkage to the unconditional Apple block at lines 711–716, where other Apple frameworks are already linked.

Proposed fix

Add to the unconditional Apple linking block (lines 711–716):

 	target_link_libraries(mumble_client_object_lib
 		PUBLIC
 			${LIB_APPKIT}
 			${LIB_APPLICATIONSERVICES}
 			${LIB_CARBON}
+			"-framework AVFoundation"
 	)

Remove from the coreaudio block (line 1039):

 	target_link_libraries(mumble_client_object_lib
 		PUBLIC
 			${LIB_AUDIOUNIT}
 			${LIB_COREAUDIO}
-			"-framework AVFoundation"
 	)

🤖 Fix all issues with AI agents

In `@src/mumble/CoreAudio.mm`:
- Around line 513-519: Update the denied-access message in the
AVAuthorizationStatusDenied case in CoreAudio.mm: replace the outdated "System
Preferences -> Security & Privacy -> Privacy -> Microphone" text with the
correct macOS 14 string "System Settings -> Privacy & Security -> Microphone" in
the QObject::tr(...) passed to Global::get().mw->msgBox, keeping the surrounding
wording and translation call intact (the code location is the
AVAuthorizationStatusDenied branch handling microphone access in CoreAudioInput
/ CoreAudio.mm).

[nicholas-lonsinger]

@davidebeatrici @Krzmbrzl

Continuing our conversation from #7066

The only thing that I could find supporting overlay was steam for steam games, everyone else had it dropped due to the security model of macOS.

I'm submitting a new PR with changes taking the target to macOS 14 (this is oldest "actively" supported build by Apple, older version don't get security updates, just a recent certificate update).

This update is in 3 commits as it's quite a lot of cleanup code. The actual "bump" did not require much, and the middle commit was not required due to the previous API only being deprecated but felt like it would be needed eventually anyway so I added it in.

Estimates are ~90% of user base is on 14, 15 or 26 (yes the numbering jumped from incremental to year based).

Machines from the year ~2018 (+/- 1 for a single line) are still supported by this version of the OS.

[davidebeatrici]

Thank you for the detailed explanation.

[davidebeatrici]

Can we wrap this in a if NOT(APPLE) block? With the overlay option disabled there shouldn't be a hard dependency on the definition.

[Krzmbrzl]

See Davide's comment - other than that I guess this is fine.

[Krzmbrzl]

@davidebeatrici @Hartmnt should we wait with merging this until we have split the 1.6 branch? I feel like this is a reasonably large change and I would probably feel better if it lived in master for a bit before becoming part of a stable release 👀

[Hartmnt]

@davidebeatrici @Hartmnt should we wait with merging this until we have split the 1.6 branch? I feel like this is a reasonably large change and I would probably feel better if it lived in master for a bit before becoming part of a stable release 👀

Yep, 100%. 1.7.x as target