Bump aiosendspin to 3.0 - #2924
Merged
Merged
Conversation
Adapt to breaking changes in aiosendspin: - Change event listener callbacks from async to synchronous - Change start_server advertise_host to advertise_addresses
Check if client still exists after waiting for pending unregister, preventing player registration attempts for disconnected clients.
maximmaxim345
marked this pull request as ready for review
January 16, 2026 12:27
maximmaxim345
marked this pull request as draft
January 16, 2026 14:06
Member
|
Have some weird syncing issues with Will investigate more into why this happens. Edit: underlying issue was probably already existing before 3.0.0, but the changed logic in |
maximmaxim345
marked this pull request as ready for review
January 20, 2026 10:59
maximmaxim345
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR shows a preview of the changes needed to adapt to breaking changes in aiosendspin 2.0 and 3.0.
The changes are due to breaking changes in Sendspin/aiosendspin#112 and Sendspin/aiosendspin#115 that we're testing out:
Coroutine) to synchronousstart_server()API changed fromadvertise_host: strtoadvertise_addresses: list[str] | NoneChanges made
provider.py:
event_cb()from async to sync_handle_client_added()and_handle_client_removed()helper methods scheduled viaself.mass.create_task()player.py:
event_cb()from async to sync (no async operations needed)group_event_cb()from async to syncgroup.stop()logic into_handle_member_removed()helper method scheduled viaself.mass.create_task()advertise_hostparameter toadvertise_addresseslist