feat: extend scanning window from 30 to 90 days#84
Open
hnshah wants to merge 1 commit intomvanhorn:mainfrom
Open
feat: extend scanning window from 30 to 90 days#84hnshah wants to merge 1 commit intomvanhorn:mainfrom
hnshah wants to merge 1 commit intomvanhorn:mainfrom
Conversation
Allows --days argument to accept values from 1-90 (previously 1-30) for pre-event deep research requiring longer historical windows. Changes: - Updated argparse choices from range(1, 31) to range(1, 91) - Updated help text to reflect new 1-90 range - Default remains 30 days (no breaking change) The recency_score function in scripts/lib/dates.py already accepts max_days parameter, so this change only required updating the CLI validation to allow larger values. Fixes mvanhorn#79
chidev
added a commit
to chidev/last30days-skill
that referenced
this pull request
Mar 25, 2026
Owner
|
Thanks Hiten, will dig in! have a bigger release coming so might need to have you rebase after. |
Author
This was referenced Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
--daysargument to accept values from 1-90 (previously 1-30) for pre-event deep research requiring longer historical windows.Changes
choicesfromrange(1, 31)torange(1, 91)Implementation Notes
The
recency_scorefunction inscripts/lib/dates.pyalready accepts amax_daysparameter, so this change only required updating the CLI validation to allow larger values. No changes to scoring logic were needed.Testing
$ python3 scripts/last30days.py --help | grep days --days N Number of days to look back (1-90, default: 30)✅ Argparse accepts values 1-90
✅ Help text updated
✅ Default remains 30
Fixes #79