docs(ci): make runner probes pool-aware - #30
Conversation
WalkthroughThe CI prompt updates runner verification to use ChangesRunner verification
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| # the target does not own, whatever it is called. | ||
|
|
||
| # 2. after step 32, the checker rejects the reference's selector | ||
| # 2. after step 32, the checker implements the ownership decision from step 3 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Keep Step 14 and Step 15 consistent for POOL_OWNED=yes.
Step 14 currently instructs adopters to empty TRUST_SPLITS without a POOL_OWNED condition. That makes the checker reject every self-hosted selector, so the approved-selector expectation in Lines 810-812 cannot pass.
State the branch explicitly: empty TRUST_SPLITS for POOL_OWNED=no, and retain only the registered target selector for POOL_OWNED=yes.
Also applies to: 810-812
Summary
Make step 15's runner-identity probes conditional on the
POOL_OWNEDdecision already recorded in step 3.For hosted-only adopters, the reference selector must still be absent and rejected. For adopters registered with the MyGuard pool, the approved selector must remain accepted while an unregistered selector must be rejected.
Adoption evidence
During
nginx-http-sentinel-moduleadoption, the target was correctly classifiedPOOL_OWNED=yesand uses the registeredbuilder02,lxcpool. The old universal acceptance text required:builder02or self-hosted selector to survive; andThose expectations contradicted steps 13–14 and would have forced a valid pool-owned adopter onto hosted runners. The target's actual two-direction policy probe showed the intended behavior:
builder02,lxcpassed andunregistered-probe,lxcfailed.Validation
LINT_ONLY=spelling ci/linter/run-all.sh ci/PROMPT.md