Add missing perl(lib)/openssl Requires to mysql-community-test package - #728
Open
sjmudd wants to merge 1 commit into
Open
Add missing perl(lib)/openssl Requires to mysql-community-test package#728sjmudd wants to merge 1 commit into
sjmudd wants to merge 1 commit into
Conversation
mysql-test-run.pl needs the perl(lib) module and shells out to the openssl CLI for feature detection, but neither is declared in packaging/rpm-oel/mysql.spec.in's %package test Requires: list. A minimal RPM install of mysql-community-test cannot run its own test suite as a result. Add both as explicit Requires:. This commit must also be applied to the 9.7 and 8.4 LTS trees. Tested: RPM build on OL10. With this patch the missing dependency is resolved.
Member
|
Thanks @sjmudd for the contributions. I think it would be worth extending the same patch to the Fedora and SLES packages as well:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
packaging/rpm-oel/mysql.spec.in's%package testdoes not declareRequires: perl(lib)orRequires: openssl. A minimal install ofmysql-community-testcannot run its own test harness:mysql-test-run.plusesperl(lib)(use lib) at compile time andshells out to the
opensslCLI for feature detection.rpm -qR mysql-community-testconfirms neither is declared; only librarysoname requires are present.
Fix
perl(lib)is a capability, not a literal package name, so itresolves correctly on el8, el9, and el10 alike.
opensslis thecorrect package name on all three.
This must also be applied to the 9.7 and 8.4 LTS trees.
Question: Am I expected to create a PR for each branch? That workflow is not 100% clear to me.
It would be good to answer this so I know expected contributor behaviour.
What does this change do?
Add both missing packages as explicit Requires: in RPM packaging.
Testing
Tested RPM build on OL10. With this patch the missing dependency is
resolved. OL8, OL9 exhibit the same behaviour and the same fix there will resolve it there.
Used https://github.com/sjmudd/mysql-rpm-builder tooling to do this.
Why is it needed?
RPM packaging should explicitly define dependencies. This is not done here.
Contributor checklist
scripts/ci/format.sh)AI assistance
Other work I was doing noticed the missing packages. AI saved me doing some of the work.
Areas touched
RPM Packaging for RHEL/OL variants. Not touched others.