Skip to content

Add missing perl(lib)/openssl Requires to mysql-community-test package - #728

Open
sjmudd wants to merge 1 commit into
mysql:trunkfrom
sjmudd:fix/test-missing-perl-lib-openssl-trunk
Open

Add missing perl(lib)/openssl Requires to mysql-community-test package#728
sjmudd wants to merge 1 commit into
mysql:trunkfrom
sjmudd:fix/test-missing-perl-lib-openssl-trunk

Conversation

@sjmudd

@sjmudd sjmudd commented Aug 24, 2026

Copy link
Copy Markdown

Problem

packaging/rpm-oel/mysql.spec.in's %package test does not declare
Requires: perl(lib) or Requires: openssl. A minimal install of
mysql-community-test cannot run its own test harness:

$ perl mysql-test-run.pl --help
Can't locate lib.pm in @INC (you may need to install the lib module)
at mysql-test-run.pl line 41.
BEGIN failed--compilation aborted at mysql-test-run.pl line 41.

mysql-test-run.pl uses perl(lib) (use lib) at compile time and
shells out to the openssl CLI for feature detection. rpm -qR mysql-community-test confirms neither is declared; only library
soname requires are present.

Fix

--- a/packaging/rpm-oel/mysql.spec.in
+++ b/packaging/rpm-oel/mysql.spec.in
@@ -481,6 +481,8 @@
 Requires:       perl(Sys::Hostname)
 Requires:       perl(Time::HiRes)
 Requires:       perl(Time::localtime)
+Requires:       perl(lib)
+Requires:       openssl
 %if 0%{?cluster}
 Requires:       %{name}-data-node%{?_isa} >= %{min}
 Requires:       %{name}-management-server%{?_isa} >= %{min}

perl(lib) is a capability, not a literal package name, so it
resolves correctly on el8, el9, and el10 alike. openssl is the
correct package name on all three.

This must also be applied to the 9.7 and 8.4 LTS trees.

Question: Am I expected to create a PR for each branch? That workflow is not 100% clear to me.
It would be good to answer this so I know expected contributor behaviour.

What does this change do?

Add both missing packages as explicit Requires: in RPM packaging.

Testing

Tested RPM build on OL10. With this patch the missing dependency is
resolved. OL8, OL9 exhibit the same behaviour and the same fix there will resolve it there.

Used https://github.com/sjmudd/mysql-rpm-builder tooling to do this.

Why is it needed?

RPM packaging should explicitly define dependencies. This is not done here.

Contributor checklist

  • [N/A] Code is formatted (scripts/ci/format.sh)
  • Commits are focused with descriptive messages

AI assistance

  • I did not use AI assistance for this contribution
  • I used AI assistance for this contribution

Other work I was doing noticed the missing packages. AI saved me doing some of the work.

Areas touched

RPM Packaging for RHEL/OL variants. Not touched others.

mysql-test-run.pl needs the perl(lib) module and shells out to the
openssl CLI for feature detection, but neither is declared in
packaging/rpm-oel/mysql.spec.in's %package test Requires: list. A
minimal RPM install of mysql-community-test cannot run its own test
suite as a result.

Add both as explicit Requires:.

This commit must also be applied to the 9.7 and 8.4 LTS trees.

Tested: RPM build on OL10. With this patch the missing dependency is
resolved.
@sjmudd
sjmudd requested a review from a team August 24, 2026 06:25
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 24, 2026
@github-actions github-actions Bot added Review Requested Review requested from code owners Build Passed PR build passed labels Aug 24, 2026
@github-actions github-actions Bot added the MTR Passed MTR suite passed label Aug 24, 2026
@gopshank
gopshank requested review from balakcha and removed request for gopshank August 24, 2026 23:42
@balakcha
balakcha requested review from bkandasa and nawazn August 25, 2026 02:32
@bkandasa

bkandasa commented Aug 27, 2026

Copy link
Copy Markdown
Member

Thanks @sjmudd for the contributions.

I think it would be worth extending the same patch to the Fedora and SLES packages as well:

  1. packaging/rpm-fedora/mysql.spec.in
  2. packaging/rpm-sles/mysql.spec.in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Passed PR build passed MTR Passed MTR suite passed OCA Verified All contributors have signed the Oracle Contributor Agreement. Review Requested Review requested from code owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants