Skip to content

Fix select scope check #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
namusyaka wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix select scope check #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/gammo/parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ def index_of_element_in_scope(scope, *match_tags)
when TABLE_SCOPE
return -1 if tag == Tags::Html || tag == Tags::Table || tag == Tags::Template
when SELECT_SCOPE
return -1 if tag == Tags::Optgroup && tag == Tags::Option
return -1 if tag == Tags::Optgroup || tag == Tags::Option
else
raise ParseError, 'unreachable parsing error, please report to github'
end
Expand Down
23 changes: 23 additions & 0 deletions test/select_scope_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
require 'test_helper'

class SelectScopeTest < Test::Unit::TestCase
include Support::Dump

test 'option and optgroup nesting' do
html = '<select><option>One<optgroup><option>Two</option></optgroup></select>'
doc = Gammo.new(html).parse
assert_equal(<<~OUT, dump_for(doc))
| <html>
| <head>
| <body>
| <select>
| <option>
| "One"
| <optgroup>
| <option>
| "Two"
OUT
)
end
end

Loading