ogma-core: Move functions related to reading specs to dedicated module. Refs #413.#414
Merged
ivanperez-keera merged 3 commits intonasa:developfrom Apr 26, 2026
Conversation
ivanperez-keera
force-pushed
the
develop-structure-spec-reading
branch
3 times, most recently
from
2715cd2 to
078ddd7
Compare
…e. Refs nasa#413. The spec and diagram parsing features inside `ogma-core` are organized differently. Diagrams have a `Data.Diagram.Parser` module that serves as entrypoint for parsing, whereas spec parsing functions are located in `Command.Common`, which acts as an entrypoint for parsing of specs from different formats. This commit moves the functions dedicated to parsing of specs from `Command.Common` into a new, internal module `Data.Spec.Parser`. The functions are renamed to use the term _read_ rather than _parse_, consistent with the interface provided by the diagram parsing module.
…pec.Parser`. Refs nasa#413. The spec and diagram parsing features inside `ogma-core` are organized differently. Diagrams have a `Data.Diagram.Parser` module that serves as entrypoint for parsing, whereas spec parsing functions are located in `Command.Common`, which acts as an entrypoint for parsing of specs from different formats. A prior commit introduced a new module `Data.Spec.Parser` that contains functions for reading specs from different formats. This commit adjusts all commands to use the functions provided by `Data.Spec.Parser`, rather than the functions that were provided by `Command.Common`.
ivanperez-keera
force-pushed
the
develop-structure-spec-reading
branch
from
078ddd7 to
9d1e511
Compare
Member
Author
|
Change Manager: Verified that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the functions related to reading specs in different formats to a new internal module, adjusting imports and calls accordingly across the codebase, as prescribed in the solution proposed for #413.