Bugfix/GCP Public access buckets are never flagged #1596

[x4v13r64]

Description

Fixes #1596 by fetching the effective value of constraints/storage.publicAccessPrevention for buckets' projects and evaluating that in the findings.

Type of change

Select the relevant option(s):

• Bug fix (non-breaking change which fixes an issue)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 20.48%. Comparing base (592505e) to head (5c20627).
Report is 24 commits behind head on develop.

❗ Current head 5c20627 differs from pull request most recent head 13e596f. Consider uploading reports for the commit 13e596f to get more accurate results

Files	Patch %	Lines
ScoutSuite/providers/gcp/facade/cloudstorage.py	0.00%	31 Missing ⚠️
...te/providers/gcp/resources/cloudstorage/buckets.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1597      +/-   ##
===========================================
- Coverage    20.52%   20.48%   -0.04%     
===========================================
  Files          384      384              
  Lines        13038    13062      +24     
===========================================
  Hits          2676     2676              
- Misses       10362    10386      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fernando-gallego]

Hi @x4v13r64 , currently it seems that this check is always flagged, as cloudstorage.projects.id.buckets.id.effective_public_access_prevention always evaluates to False.