Skip to content

Fix case sensitivity issue in ActivityLogAlerts (Azure region name) #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chopeen wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix case sensitivity issue in ActivityLogAlerts (Azure region name) #1645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ScoutSuite/providers/azure/resources/loggingmonitoring/activity_log_alerts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def _parse_log_alerts(self, log_alerts):

def ensure_alert_exist(self, log_alerts, equals_value: str):
for log_alert in log_alerts:
if log_alert.location == 'Global' and log_alert.enabled:
if log_alert.location.lower() == 'global' and log_alert.enabled:
if '/subscriptions/' + self.subscription_id in log_alert.scopes:
for condition in log_alert.condition.all_of:
if condition.field == 'operationName' and condition.equals == equals_value:
Expand Down