fix: empty http request body in Connection.Call#171
Open
childe wants to merge 1 commit intoncw:masterfrom
Open
fix: empty http request body in Connection.Call#171childe wants to merge 1 commit intoncw:masterfrom
childe wants to merge 1 commit intoncw:masterfrom
Conversation
RequestOpts.Body is read out in the first try, and will be empty in the second retry.
ncw
reviewed
Oct 6, 2021
Owner
ncw
left a comment
ncw
left a comment
There was a problem hiding this comment.
Thank you for looking at this.
Unfortunately I don't think this will work as written - see inline.
There may be a way to fix it though - more discussion needed
| retries = c.Retries | ||
| } | ||
| var req *http.Request | ||
| reqBodyBuf, err := ioutil.ReadAll(p.Body) |
Owner
There was a problem hiding this comment.
The Body is used to upload objects so could easily be a 5G file which we don't want to buffer in memory.
Where are you seeing this problem?
There are quite a few possible workaround, but to suggest one I need more context.
Author
There was a problem hiding this comment.
Sorry for my very late rseponse. I missed it earlier
I see the problem is fixed in d2de41c to some extent. Maybe it should always Seek(0, io.SeekStart) , not only in 401 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestOpts.Body is read out in the first try, and will be empty in the second retry.