Support for parsing json in ObjectNames()#182
Open
yheonhochoi wants to merge 1 commit intoncw:masterfrom
Open
Conversation
Author
|
Can I get an update on this? It's not a big change, but it's a necessary setting in my environment. Any additional feedback is welcome and will be checked. |
ncw
reviewed
Jun 10, 2023
Owner
ncw
left a comment
ncw
left a comment
There was a problem hiding this comment.
Sorry for the delay.
This code looks OK.
I'd like to know why swift is returning JSON when we haven't asked for it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #181
It does not contain implementations for other types.
However, if a request is made with json format, the body of the received resp is parsed and the name list is returned.