Migrate frontend UI primitives to Nebari design registry - #460
Open
MUFFANUJ wants to merge 7 commits into
Open
Conversation
✅ Deploy Preview for nebi-docs canceled.
|
Resolved PublishDialog.test.tsx conflicts in favor of the Nebari Select (combobox) interaction pattern, porting main's focus assertion and adapting the new refreshes-defaults test from native selectOptions to combobox clicks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tion The merge from main brought in tests written against the old native select and Radix dialog autofocus. The Nebari/Base UI Select trigger is a combobox button, so assert on its visible text instead of .value, and drop the focus wait the Base UI dialog no longer satisfies. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Closes #439
What does this implement/fix?
Put a
xin the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1or#in markdown).Non-text content
Any other comments?
This PR migrates Nebi’s frontend
shadcnsetup to the@nebari designregistry, replaces the registry-backed UI primitives with Nebari versions, reconciles theme/utils integration, and keeps registry-absent local components explicitly documented. It also updates affected call sites to the new Base UI component APIs while preserving existing behavior and accessibility.frontend/components.jsonwith the@nebariregistry@nebari/themeinfrontend/src/index.css@nebari/utilswith existingcn,capitalize, andgetWorkspaceStatusColorbutton,input,textarea,badge,card,dialog,tabs,selectspinneralert-dialog,select-v2,split-button,confirm-dialog,user-badge--color-primary-hoverand--color-nav-hoverDialog,Tabs,Select, andButtonAPIsselectref compatibility exception