Open
Conversation
balalofernandez
force-pushed
the
alvaro/google-genai-provider
branch
from
362d6a1 to
967abb3
Compare
serengil
reviewed
Feb 20, 2026
serengil
reviewed
Feb 20, 2026
serengil
reviewed
Feb 20, 2026
serengil
reviewed
Feb 20, 2026
Contributor
|
Would you please add google gen ai into README's Optional Dependencies section also. |
serengil
requested changes
Feb 20, 2026
Contributor
serengil
left a comment
serengil
left a comment
There was a problem hiding this comment.
Added a couple of comments. Happy to discuss.
- Introduced and classes for embedding and LLM functionalities using Google's Gemini API. - Updated to include dependency. - Added example scripts for using and . - Enhanced documentation to include new classes and their usage. - Updated tests for the new functionalities, ensuring proper error handling and response validation.
- Added support for Google Gemini embeddings and LLMs in the README. - Updated example scripts to assert the presence of the GOOGLE_API_KEY environment variable. - Modified the default embedding model and dimension to use environment variables for better configurability. - Improved error handling in the GeminiEmbedder class to ensure valid responses from the API.
balalofernandez
force-pushed
the
alvaro/google-genai-provider
branch
from
967abb3 to
9555678
Compare
Author
|
Thank you for your comments, I fixed them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GeminiEmbedderandGeminiLLMclasses for embedding and LLM functionalities using Google's Gemini API.pyproject.tomlto includegoogle-genaidependency.GeminiEmbedderandGeminiLLM.Type of Change
Complexity
Low
Complexity:
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):