Check postgresql ALPN value for direct SSL connections#12783
Draft
Check postgresql ALPN value for direct SSL connections#12783
Conversation
9075 tests run: 8414 passed, 0 failed, 661 skipped (full report)Flaky tests (3)Postgres 17
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
bfb86b2 at 2025-07-30T14:27:58.353Z :recycle: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Neon proxy accepts direct SSL Postgres-protocol connections with no ALPN protocol specified, whereas a real Postgres server does not.
Summary of changes
Make proxy reject direct SSL connections unless the ALPN protocol is
postgresql. Traditional SSL connections (starting with anSSLRequestmessage) are unaffected.Testing