Skip to content

feat(clice): add clice lsp config#4301

Open
tsurumi-yizhou wants to merge 3 commits intoneovim:masterfrom
tsurumi-yizhou:clice
Open

feat(clice): add clice lsp config#4301
tsurumi-yizhou wants to merge 3 commits intoneovim:masterfrom
tsurumi-yizhou:clice

Conversation

@tsurumi-yizhou
Copy link
Copy Markdown

No description provided.

lsp/clice.lua Outdated
---@type vim.lsp.Config
return {
cmd = { 'clice', '--mode=pipe' },
filetypes = { 'cpp', 'cc', 'cxx', 'hpp', 'hxx', 'h', 'ixx', 'cppm' },
Copy link
Copy Markdown
Member

@justinmk justinmk Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all of these valid Vim filetypes, or are some of these file extensions? filetypes does not support file extensions yet (and when it does, it will require a "glob" expression, thus extensions such as h here are invalid).

The filetype for a .h file is cpp, not h.

---@type vim.lsp.Config
return {
cmd = { 'clice', '--mode=pipe' },
filetypes = { 'cpp' },
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may also want to add c here, since a c++ project may have both cpp and c files

cmd = { 'clice', '--mode=pipe' },
filetypes = { 'cpp' },
root_markers = {
'.git/',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'.git/',
'.git',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants