Skip to content

Enable ko and pyspelling tools#11

Open
electrocucaracha wants to merge 3 commits intonephio-project:mainfrom
electrocucaracha:feature-ko
Open

Enable ko and pyspelling tools#11
electrocucaracha wants to merge 3 commits intonephio-project:mainfrom
electrocucaracha:feature-ko

Conversation

@electrocucaracha
Copy link
Copy Markdown
Member

@electrocucaracha electrocucaracha commented Apr 26, 2023

This PR provides the following changes:

  • Enables the ko tool to simplify local testing. The make kind-deploy deploys a KinD cluster with Multus-CNI and builds/deploys the controller.
  • Provides a spellchecker for documentation. tox -e spell
  • Refactors the container runtime detection.

@electrocucaracha
Add ko support
54678ad 
ko tool automates the processs to build and test go lang process. It provides
support to KinD clusters as well as integrates easily with kustomize tool.
This changes provides the `kind-deploy` target which covers the e2e provisioning
process in a local cluster.

Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Add spellchecker
4b81278 
Several typos can be catch from spellchecker tools. This change provides an
automated way to validate typos on documentation.

Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Refactor container runtime detection
c766ec3 
Signed-off-by: Victor Morales <v.morales@samsung.com>
@nephio-prow nephio-prow bot requested review from johnbelamaric and s3wong April 26, 2023 04:17
@nephio-prow
Copy link
Copy Markdown
Contributor

nephio-prow bot commented Apr 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: electrocucaracha
Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval by writing /assign @johnbelamaric in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow
Copy link
Copy Markdown
Contributor

nephio-prow bot commented Apr 26, 2023

Hi @electrocucaracha. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s3wong
Copy link
Copy Markdown
Contributor

s3wong commented Apr 27, 2023

/ok-to-test

@electrocucaracha
Copy link
Copy Markdown
Member Author

electrocucaracha commented May 18, 2023

@s3wong is there any roadblock on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@s3wong s3wong Awaiting requested review from s3wong

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@electrocucaracha @s3wong