feat: netbird load balancer class#86
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for Services with loadBalancerClass: netbird, enabling the operator to inject LoadBalancer ingress information into the Service status. Additionally, it fixes an issue where NBRoutingPeer pod labels were being incorrectly applied.
Key Changes:
- Implements LoadBalancer status injection for Services with
loadBalancerClass: netbird - Fixes duplicate pod label assignment in NBRoutingPeer controller
- Updates RBAC permissions to allow Service status updates
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/controller/service_controller.go | Adds deferred status update logic and LoadBalancer ingress injection for netbird class services |
| internal/controller/service_controller_test.go | Adds test coverage for LoadBalancer class functionality |
| internal/controller/nbroutingpeer_controller.go | Removes duplicate pod label assignment that was overwriting intended labels |
| helm/kubernetes-operator/templates/rbac.yaml | Adds services/status permission required for status updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
21c75d3 to
b90f568
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ihor Hrytskiv <ihor.hrytskiv@macpaw.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When
loadBalancerClass: netbirdis set, the operator now injectsthe proper LoadBalancer ingress into Service status.