Skip to content

feat: netbird load balancer class#86

Open
ihor-hrytskiv wants to merge 2 commits intonetbirdio:mainfrom
ihor-hrytskiv:main
Open

feat: netbird load balancer class#86
ihor-hrytskiv wants to merge 2 commits intonetbirdio:mainfrom
ihor-hrytskiv:main

Conversation

@ihor-hrytskiv
Copy link

  • Added support for Services with type LoadBalancer.
    When loadBalancerClass: netbird is set, the operator now injects
    the proper LoadBalancer ingress into Service status.
status:                                                                                                                         
  loadBalancer:                                                                                                                 
    ingress:                                                                                                                    
    - hostname: cilium-gateway-netbird-gateway.gateway-api-test.svc.cluster.local 
  • Fixed applying labels to NBRoutingPeer pods.

Copilot AI review requested due to automatic review settings December 2, 2025 11:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Services with loadBalancerClass: netbird, enabling the operator to inject LoadBalancer ingress information into the Service status. Additionally, it fixes an issue where NBRoutingPeer pod labels were being incorrectly applied.

Key Changes:

  • Implements LoadBalancer status injection for Services with loadBalancerClass: netbird
  • Fixes duplicate pod label assignment in NBRoutingPeer controller
  • Updates RBAC permissions to allow Service status updates

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
internal/controller/service_controller.go Adds deferred status update logic and LoadBalancer ingress injection for netbird class services
internal/controller/service_controller_test.go Adds test coverage for LoadBalancer class functionality
internal/controller/nbroutingpeer_controller.go Removes duplicate pod label assignment that was overwriting intended labels
helm/kubernetes-operator/templates/rbac.yaml Adds services/status permission required for status updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ihor-hrytskiv ihor-hrytskiv force-pushed the main branch 2 times, most recently from 21c75d3 to b90f568 Compare December 2, 2025 11:33
@ihor-hrytskiv ihor-hrytskiv requested a review from Copilot December 2, 2025 13:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Ihor Hrytskiv <ihor.hrytskiv@macpaw.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants