FindAllStats: Fix to get the json of resource when not an array#36
Open
ak1ra24 wants to merge 1 commit intonetscaler:mainfrom
Open
FindAllStats: Fix to get the json of resource when not an array#36ak1ra24 wants to merge 1 commit intonetscaler:mainfrom
ak1ra24 wants to merge 1 commit intonetscaler:mainfrom
Conversation
senhub-io
pushed a commit
to senhub-io/adc-nitro-go
that referenced
this pull request
Dec 11, 2025
…node)
This fixes the panic that occurs when FindAllStats() is called on singleton
resources like system, ns, ssl, or hanode. These resources return a single
object (map[string]interface{}) instead of an array ([]interface{}).
The fix uses a type switch to handle both cases:
- Array response: process normally (lbvserver, service, servicegroup)
- Singleton response: wrap in array to maintain consistent return type
This resolves issue netscaler#35 and implements the fix from PR netscaler#36.
TEMPORARY FORK: This is a temporary fork until the official SDK merges the fix.
Upstream PR: netscaler#36
Upstream Issue: netscaler#35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #35.
The FindAllStats function was implemented with the condition that the json resource tag contains an array,
so it has been modified to handle
[]interface{}ormap[string]interface{}in the type evaluation.