Disable Tracy debug bar in mcp-inspector.php#2
Open
eydun wants to merge 3 commits intonette:masterfrom
Open
Conversation
Conditionally disable Tracy\Debugger::$showBar in www/mcp-inspector.php if the Tracy Debugger class exists.
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the MCP inspector HTTP endpoint where Tracy's debug bar was corrupting JSON-RPC responses by appending HTML comments to the output buffer. The fix disables Tracy's debug bar before processing requests in the HTTP mode entry point.
Changes:
- Added a guard to disable Tracy's debug bar in the HTTP mode entry point (
www/mcp-inspector.php)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracy appends an HTML comment block to the output buffer. This pollutes JSON-RPC responses and causes clients to fail
with Unexpected non-whitespace character after JSON.
Added a guard to disable the bar before the request is processed.