Skip to content

fix(autocomplete): respect privacy settings for sharing#12715

Merged
hamza221 merged 1 commit intomainfrom
fix/respect-sharing-enumeration
Apr 22, 2026
Merged

fix(autocomplete): respect privacy settings for sharing#12715
hamza221 merged 1 commit intomainfrom
fix/respect-sharing-enumeration

Conversation

@hamza221
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 commented Apr 13, 2026

How to test:

  1. Admin settings -> sharing -> Privacy settings for sharing
  2. edit the settings and make sure that both :
  • Adress autocompletion in composer
  • @ the mention shortcut in composer

respect them

Comment thread lib/Service/ContactsIntegration.php Outdated
Comment thread tests/Unit/Service/Phishing/ContactCheckTest.php Outdated
Comment thread tests/Unit/Service/PhishingDetection/ContactCheckTest.php Outdated
Comment thread tests/Unit/Service/ContactsIntegrationTest.php Outdated
@hamza221
Copy link
Copy Markdown
Contributor Author

@ChristophWurst I've been actually wondering if we want to always allow full sab access to phishing detection check? maybe without exposing the actual contact ?

@hamza221 hamza221 requested a review from ChristophWurst April 15, 2026 12:05
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the fix/respect-sharing-enumeration branch from ab013c7 to b7e6088 Compare April 22, 2026 12:28
@hamza221 hamza221 enabled auto-merge April 22, 2026 12:28
@hamza221
Copy link
Copy Markdown
Contributor Author

/backport to stable5.7

@hamza221
Copy link
Copy Markdown
Contributor Author

/backport to stable5.6

@hamza221
Copy link
Copy Markdown
Contributor Author

/backport to stable5.5

@hamza221
Copy link
Copy Markdown
Contributor Author

/backport to stable3.7

@hamza221 hamza221 merged commit 4caab1c into main Apr 22, 2026
42 checks passed
@hamza221 hamza221 deleted the fix/respect-sharing-enumeration branch April 22, 2026 13:08
@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 22, 2026

The backport to stable3.7 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable3.7
git pull origin stable3.7

# Create the new backport branch
git checkout -b backport/12715/stable3.7

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b7e60882

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/12715/stable3.7

Error: Failed to check for changes with origin/stable3.7: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 22, 2026

The backport to stable5.5 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable5.5
git pull origin stable5.5

# Create the new backport branch
git checkout -b backport/12715/stable5.5

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b7e60882

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/12715/stable5.5

Error: Failed to check for changes with origin/stable5.5: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 22, 2026

The backport to stable5.6 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable5.6
git pull origin stable5.6

# Create the new backport branch
git checkout -b backport/12715/stable5.6

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b7e60882

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/12715/stable5.6

Error: Failed to check for changes with origin/stable5.6: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 22, 2026

The backport to stable5.7 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable5.7
git pull origin stable5.7

# Create the new backport branch
git checkout -b backport/12715/stable5.7

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b7e60882

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/12715/stable5.7

Error: Failed to check for changes with origin/stable5.7: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@hamza221
Copy link
Copy Markdown
Contributor Author

/backport to stable5.7 please

@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 22, 2026

The backport to stable5.7 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable5.7
git pull origin stable5.7

# Create the new backport branch
git checkout -b backport/12715/stable5.7

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b7e60882

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/12715/stable5.7

Error: Failed to check for changes with origin/stable5.7: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants