refactor: improve InitialStateService robustness and maintainability#5329
Open
joshtrichards wants to merge 1 commit intomainfrom
Open
refactor: improve InitialStateService robustness and maintainability#5329joshtrichards wants to merge 1 commit intomainfrom
joshtrichards wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Josh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
InitialStateServiceclass to enhance robustness, maintainability, and clarity:$hasProvidedOptionsflags to ensure option state is only set once per request.urlsrc,fileId,token) inprovideDocument(), throwing exceptions when missing to prevent frontend/session errors.setThemeOptions,setLogoOption), improving readability and separation of concerns.These improvements collectively make the service safer, easier to follow, and more maintainable for future development.
No breaking changes introduced; the new exceptions will only trigger on situations that would have already failed in some other way.
TODO
Checklist