Skip to content

Fix - Bug in reactions #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sowjanyakch wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix - Bug in reactions #5662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fdc5aa
don't update message flow
sowjanyakch Dec 22, 2025
0e1ab37
don't show zero emoji count
sowjanyakch Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/com/nextcloud/talk/chat/data/network/OfflineFirstChatRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,8 @@ class OfflineFirstChatRepository @Inject constructor(
when (messageJson.systemMessageType) {
ChatMessage.SystemMessageType.REACTION,
ChatMessage.SystemMessageType.REACTION_REVOKED,
ChatMessage.SystemMessageType.REACTION_DELETED,
ChatMessage.SystemMessageType.REACTION_DELETED -> {
}
Copy link
Collaborator

@mahibi mahibi Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will completely ignore processing of reactions that were done on other clients

ChatMessage.SystemMessageType.MESSAGE_DELETED,
ChatMessage.SystemMessageType.POLL_VOTED,
ChatMessage.SystemMessageType.MESSAGE_EDITED -> {
Expand Down
10 changes: 6 additions & 4 deletions app/src/main/java/com/nextcloud/talk/repositories/reactions/ReactionsRepositoryImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,13 @@ class ReactionsRepositoryImpl @Inject constructor(private val ncApi: NcApi, priv
message.reactionsSelf = ArrayList()
}

var amount = message.reactions!![emoji]
if (amount == null) {
amount = 0
val currentEmojiCount = message.reactions!![emoji] ?: 0
val newEmojiCount = currentEmojiCount - 1
if (newEmojiCount <= 0) {
message.reactions!!.remove(emoji)
} else {
message.reactions!![emoji] = newEmojiCount
}
message.reactions!![emoji] = amount - 1
message.reactionsSelf!!.remove(emoji)

// 3. Call DAO again, to update the singular ChatMessageEntity with params
Expand Down
Loading