Skip to content

Fix error checking in workflow emits #7058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bentsherman wants to merge 1 commit into
base: master
Choose a base branch
from
+49 −0
Draft

Fix error checking in workflow emits #7058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/nf-lang/src/main/java/nextflow/script/control/VariableScopeVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ private void visitTypedOutputs(Statement outputs, String typeLabel) {
var output = es.getExpression();
VariableExpression target;
if( output instanceof VariableExpression ve ) {
visit(ve);
target = ve;
}
else if( output instanceof AssignmentExpression assign ) {
Expand Down
48 changes: 48 additions & 0 deletions modules/nf-lang/src/test/groovy/nextflow/script/control/ScriptResolveTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,54 @@ class ScriptResolveTest extends Specification {
errors[0].getStartLine() == 3
errors[0].getStartColumn() == 9
errors[0].getOriginalMessage() == 'Variables in a closure should be declared with `def`'

when:
errors = check(
'''\
workflow hello {
emit:
x
}
'''
)
then:
errors.size() == 1
errors[0].getStartLine() == 3
errors[0].getStartColumn() == 5
errors[0].getOriginalMessage() == '`x` is not defined'

when:
errors = check(
'''\
workflow hello {
emit:
x = y
}
'''
)
then:
errors.size() == 1
errors[0].getStartLine() == 3
errors[0].getStartColumn() == 9
errors[0].getOriginalMessage() == '`y` is not defined'

when:
errors = check(
'''\
workflow hello {
emit:
x + y
}
'''
)
then:
errors.size() == 2
errors[0].getStartLine() == 3
errors[0].getStartColumn() == 5
errors[0].getOriginalMessage() == '`x` is not defined'
errors[1].getStartLine() == 3
errors[1].getStartColumn() == 9
errors[1].getOriginalMessage() == '`y` is not defined'
}

def 'should report an error for an undefined function' () {
Expand Down
Loading