Migrate hello_nf-core to nf-core tools 4.0.2 + v2 parser#970
Merged
Conversation
…bleshooting note [skip ci]
… 26.04 output [skip ci]
… 4 snippets [skip ci]
The positional form 'cowpy "Hello Containers"' does not put the text in the speech bubble (cowpy reads the message from stdin); it printed the cowacter self-description. Use the stdin form, matching how the pipeline module invokes cowpy, so the documented output is what the command actually produces. [skip ci]
… under v1 parser) [skip ci]
… default [skip ci]
… nf-co2footprint 1.2.0->1.3.0 [skip ci]
…utput for 26.04 (v1) [skip ci]
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…-schema 2.7.2, v2-clean All 5 solutions run to completion under Nextflow 26.04.4 v2 parser. validate_params handled via config boolean in parts 2-4 (preserves lesson 5's schema-validation exercise); part 5 keeps the greetings schema + validation on. [skip ci]
… hash consistency [skip ci]
…rror text + output) [skip ci]
…st-merge with #961 publishing [skip ci]
…prose for v2 static type checking [skip ci]
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…a typed params.yaml Validated end-to-end on native x86 (22-task molkart run). Resolves the v2 integer-param typing issue (--flag value ints arrive as strings under the v2 parser) by switching documented commands to a typed params.yaml; also fixes a fabricated resume block and a wrong task count. [skip ci]
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Runs under the 26.04 default v2 parser (no NXF_SYNTAX_PARSER=v1). Boolean params set via params-file/config instead of bare CLI flags (which the v2 parser types as strings). Orientation rewritten to v2 + nf-core 4.0.2; devcontainer pin -> 4.0.2. All console output regenerated from genuine 4.0.2/v2 runs on x86. [skip ci]
…-4.0 # Conflicts: # docs/en/docs/hello_nf-core/00_orientation.md # docs/en/docs/hello_nf-core/01_run_demo.md # docs/en/docs/hello_nf-core/02_rewrite_hello.md # docs/en/docs/hello_nf-core/03_use_module.md
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Nextflow linting complete!
💡 Tip: Click filename locations to go directly to that code. View all 51 issuesView formatting changes
|
… 3 section 1.4, v2 compat note - Fix leaked author path in Part 3 run output (replace /home/ubuntu/hnc-scratch with codespace paths) - Move boolean params warning from orientation to Part 1 section 3.1.2 where it first applies - Restructure Part 3 section 1.4: tip and NotADirectoryError explanation as prose, add modules.json content, rewrite nf-core modules list local note - Add v2 parser compatibility note for outputDir/workflow.output.mode in Part 2 section 5.4 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…csv as course materials Replace learner-created files with pre-provided equivalents in Part 1: - Add my_params.yml (skip_trim: true) and malformed_samplesheet.csv to hello-nf-core/ - Update Part 1 section 3.1.2 and 3.1.4 to reference provided files instead of instructing learners to create them - Update orientation directory tree and file descriptions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…e exercises in Part 1 - Add custom.config (FASTQC resource override + SEQTK_TRIM ext.args) to hello-nf-core/ - Merge sections 3.2.1 and 3.2.2 into a single exercise showing both overrides at once - Update orientation directory tree and file descriptions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r pipeline users Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tputs - Fix process counts and add COWPY to all run outputs (1.2.0 added COWPY process) - Remove multiqc_plots from demo-results tree (no longer produced in 1.2.0) - Update directory count from 13 to 12 accordingly - Update conf/ listing to include container config files added in 1.2.0 - Update test.config snippet: trailing comma in resourceLimits, aligned input field - Update modules.config snippet: ext.args spacing to match actual file - Add missing ' -- Check .nextflow.log' line to validation error outputs - Fix tree ordering to Linux case-sensitive sort (uppercase before lowercase) - Fix 'three tools' → 'four tools' and backtick process names in prose - Fix 'Don't worry' to neutral phrasing - Update docs link from 1.1.0 to 1.2.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…compat warning, fix tree ordering - Replace all !!! note with !!! info across Parts 2-5 (18 instances) - Add v2 parser compatibility warning to orientation page - Fix tree ordering in Part 2 core-hello scaffold (README.md, docs/ subdir) - Revert style fix to 'Don't worry' line in Part 1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vdauwera
approved these changes
Jul 4, 2026
vdauwera
left a comment
Collaborator
There was a problem hiding this comment.
Made some additional refinements and added a note of caution about potentially needing to set syntax parser to v1 to run other nf-core pipelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the hello_nf-core course from nf-core tools 3.5.2 → 4.0.2 so it runs under the Nextflow 26.04 default v2 parser, removing the
NXF_SYNTAX_PARSER=v1workaround.What changed
core-hello-start,part2-part5) verified running to completion under the v2 parser on native x86.validate_params: the--validate_params falseCLI flag is a no-op under v2 (bare CLI values are typed as strings;"false"is truthy - Using strict syntax causes template to raise an error when setting boolean options on CLI nf-core/tools#4100). Parts 2-4 now setvalidate_params = falsein config (a real boolean), preserving the Part 5 lesson that teaches the schema-validation transformation. The CLI flag is gone from all commands.nf-core/tools version 4.0.2create banner and theGenerated container configs...line.-params-file/config, not bare CLI flags (the v2 string-typing behavior - it also affected Part 1's--skip_trim, now shown via a params file).uv-toolspin →nf-core==4.0.2.Known 4.0 behavior documented
nf-core modules installraisesNotADirectoryErroron the course's single-file local modules (4.0 expects directory-style); the install still completes, so Part 3 now verifies viamodules.jsonwith a warning admonition.Not verified (inherent)
Interactive nf-core TUIs (
pipelines create,schema build,modules create) can't be driven headlessly; their banners/versions are genuine 4.0.2, the click-through steps are unchanged.🤖 Generated with Claude Code