Skip to content

Replace stuff that's bothering me#28

Open
matthdsm wants to merge 16 commits intodevfrom
fix/ditch_stuff
Open

Replace stuff that's bothering me#28
matthdsm wants to merge 16 commits intodevfrom
fix/ditch_stuff

Conversation

@matthdsm
Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Copy Markdown
Member

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes 🥳

@ToonRosseel could you double check the targeted flow here? I'm not familiar enough with it

@ToonRosseel
Copy link
Copy Markdown
Contributor

LGTM, thanks for the fixes 🥳

@ToonRosseel could you double check the targeted flow here? I'm not familiar enough with it

I’ve addressed the breaking changes, so the targeted flow should be good now.

@ToonRosseel ToonRosseel mentioned this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants