Skip to content

adding in moire script - #37

Open
nickjhathaway wants to merge 3 commits into
devfrom
feature/adding_moire
Open

adding in moire script#37
nickjhathaway wants to merge 3 commits into
devfrom
feature/adding_moire

Conversation

@nickjhathaway

Copy link
Copy Markdown
Contributor

adding nextflow process to run moire r wrapper

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/plasmodiumdrugres branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).

@kathrynmurie

Copy link
Copy Markdown
Collaborator

This looks great! Hadn't seen this way around it before and it's nice to separate it out and keep the module neat

If the results from moire are stochastic it might still be useful to still check the header is formatted correctly with something like this

with(process.out.coi_summary) {
with(get(0)) {
assert get(1) != null
assert path(get(1)).readLines()[0].contains("specimen_id\tcoi")
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants