Skip to content

Comments

feat(query-client): support for passing custom QueryClient instance …#208

Merged
NetanelBasal merged 1 commit intongneat:mainfrom
radekdob:provide_query_with_fn
Feb 13, 2025
Merged

feat(query-client): support for passing custom QueryClient instance …#208
NetanelBasal merged 1 commit intongneat:mainfrom
radekdob:provide_query_with_fn

Conversation

@radekdob
Copy link
Contributor

…via function

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

provideQueryClient() function accepts only QueryClient instance, so it is not possible to pass a custom instance being in injection context.
Accepting a function as argument allows to be in injection context and pass object which was e.g. provided via DI in different place.

Issue Number: 204

What is the new behavior?

provideQueryClient() function accepts also a function as argument

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

@luii luii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NetanelBasal NetanelBasal merged commit 59eca0d into ngneat:main Feb 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants