Skip to content

Comments

chore(deps): update peerDependencies to 20.x.x#211

Merged
NetanelBasal merged 15 commits intongneat:mainfrom
luii:main
Jun 13, 2025
Merged

chore(deps): update peerDependencies to 20.x.x#211
NetanelBasal merged 15 commits intongneat:mainfrom
luii:main

Conversation

@luii
Copy link
Contributor

@luii luii commented Jun 11, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #210

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netanel-utila
Copy link

Hi, can you run the Angular v20 migration, please?

@luii
Copy link
Contributor Author

luii commented Jun 11, 2025

Hi, can you run the Angular v20 migration, please?

Will do after my work today 👍

@luii
Copy link
Contributor Author

luii commented Jun 11, 2025

Hmm, this is weird, doing a local npm ci and npm run build:all does not yield that result.

Oh btw. i updated NX to 21.x.x-beta.5 since its the only version that currently supports Angular 20.0.2, maybe we can leave it open until they've released 21 fully.

@luii
Copy link
Contributor Author

luii commented Jun 11, 2025

I think we need to bump the ci workflow file's node version for the build error.
If you would like me to do it then just give me the node version i should bump it to.

https://github.com/ngneat/query/actions/runs/15580584489/workflow?pr=211#L28

Solution found here:
ng-packagr/ng-packagr#3071 (comment)

luii added 2 commits June 13, 2025 06:58
additionally setting the node version of the ci workflow to 22
to mitigate a building error
@luii
Copy link
Contributor Author

luii commented Jun 13, 2025

Should be good to go imho, i bumped the versions and updated the ci workflow @NetanelBasal

@NetanelBasal NetanelBasal merged commit c080581 into ngneat:main Jun 13, 2025
1 check passed
@NetanelBasal
Copy link
Member

@luii after installing the new version we get:

✘ [ERROR] No matching export in "node_modules/@tanstack/query-core/build/modern/index.js" for import "skipToken"
    node_modules/@ngneat/query/fesm2022/ngneat-query.mjs:4:9:
      4 │ import { skipToken, QueryClient as QueryClient$1, notifyManager, In...
        ╵          ~~~~~~~~~

  let error = new Error(text);

@luii
Copy link
Contributor Author

luii commented Jun 13, 2025

@luii after installing the new version we get:

✘ [ERROR] No matching export in "node_modules/@tanstack/query-core/build/modern/index.js" for import "skipToken"
    node_modules/@ngneat/query/fesm2022/ngneat-query.mjs:4:9:
      4 │ import { skipToken, QueryClient as QueryClient$1, notifyManager, In...
        ╵          ~~~~~~~~~

  let error = new Error(text);

do you have any steps to reproduce @NetanelBasal ?

@NetanelBasal
Copy link
Member

I just installed the new version in our application. Did you also tried to do it?

@luii
Copy link
Contributor Author

luii commented Jun 13, 2025

used a entire new angular project and it builds without problems
do you have @tanstack/query-core in your apps package json maybe that its overriding the peer dependency?

@luii
Copy link
Contributor Author

luii commented Jun 13, 2025

other then that maybe completly removing node_modules and package-lock.json could fix it

@NetanelBasal
Copy link
Member

It seems that there is no such version invalid: "^5.80.6" from node_modules/@ngneat/query

@NetanelBasal
Copy link
Member

It's 5.80.7

@luii
Copy link
Contributor Author

luii commented Jun 13, 2025

It seems that there is no such version invalid: "^5.80.6" from node_modules/@ngneat/query

https://github.com/TanStack/query/releases/tag/v5.80.6
https://www.npmjs.com/package/@tanstack/query-core?activeTab=versions

both of them list 5.80.6 as version, and putting ^ infront of it would eventually, when someone installs it for the first time go up to the closest minor and patch version which would be v5.80.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants