fix(entity): infer selectId return type from adapter configuration#5085
Open
timdeschryver wants to merge 3 commits intomainfrom
Open
fix(entity): infer selectId return type from adapter configuration#5085timdeschryver wants to merge 3 commits intomainfrom
timdeschryver wants to merge 3 commits intomainfrom
Conversation
✅ Deploy Preview for ngrx-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ngrx-site-v21 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
timdeschryver
commented
Feb 18, 2026
| /** | ||
| * Creates an entity adapter with methods for managing collections of entities in state. | ||
| * | ||
| * @description |
Member
Author
There was a problem hiding this comment.
TODO: add breaking change note to commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #5073
The
IdSelectoralways returnedstring | number.What is the new behavior?
The return type if inferred by the adapter:
selectIdmethod, if provided in the config optionsDoes this PR introduce a breaking change?
I'm also ok with flagging this as a breaking change.
Other information