refactor(data): refactor data module tests to use vitest#5095
Merged
markostanimirovic merged 4 commits intongrx:mainfrom Feb 21, 2026
Merged
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ngrx-site-v21 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
JulienMichelFr
force-pushed
the
chore/migrate-data-tests-to-vitest
branch
from
277ac83 to
2e1d368
Compare
JulienMichelFr
force-pushed
the
chore/migrate-data-tests-to-vitest
branch
from
2e1d368 to
04cbb42
Compare
Member
There was a problem hiding this comment.
This looks good again @JulienMichelFr !
I only noticed the snapshot at modules/schematics/src/data/snapshots/index.spec.ts still seems to be a Jest version.
Could you take a look at this please?
timdeschryver
approved these changes
Feb 19, 2026
Member
timdeschryver
left a comment
timdeschryver
left a comment
There was a problem hiding this comment.
Nevermind my comment, that's for the schematics module 😅
markostanimirovic
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Data module was using Jasmine as test runner
Closes #5091
What is the new behavior?
This module now use Vitest as test runner
Does this PR introduce a breaking change?
Other information