Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jan 13, 2026

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, on day 1 of the month ( * 0-3 1 * * ) in timezone US/Central, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

Test Results

  120 files  ±0    120 suites  ±0   3m 25s ⏱️ -7s
  249 tests ±0    247 ✅ ±0   2 💤 ±0  0 ❌ ±0 
2 490 runs  ±0  2 460 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 90e1270. ± Comparison against base commit 6969071.

♻️ This comment has been updated with latest results.

@renovate renovate bot force-pushed the users/renovate/lock-file-maintenance branch from b114917 to 1fec57e Compare January 14, 2026 16:05
@renovate renovate bot force-pushed the users/renovate/lock-file-maintenance branch from 1fec57e to 85c1f8d Compare January 19, 2026 23:40
Copy link
Collaborator

@jfriedri-ni jfriedri-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll address the new style checks today.

@bkeryan
Copy link
Collaborator

bkeryan commented Jan 20, 2026

I'll address the new style checks today.

@mshafer-NI I forgot, is ni-python-styleguide supposed to lock black to a specific year?

@jfriedri-ni

@mshafer-NI
Copy link
Collaborator

I'll address the new style checks today.

@mshafer-NI I forgot, is ni-python-styleguide supposed to lock black to a specific year?

@jfriedri-ni

No, we chose to let that be handled via poetry.lock on the client side (which allows black to work an update through our eco-system without re-releasing ni-python-styleguide)

@jfriedri-ni
Copy link
Collaborator

jfriedri-ni commented Jan 20, 2026

There are new sphinx and autoapi warnings that fail the doc checks for the ni.protobuf.types and ni.panels.v1.proto packages, something related to how the backing proto files import another proto and use its type as a member.

I cannot spend more time on this right now, so I'll suppress the warning and create an issue.

Update

image

I will pin sphinx's major version. Such an upgrade doesn't seem like a valid use-case for 'lock file maintenance'

@renovate
Copy link
Contributor Author

renovate bot commented Jan 20, 2026

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@bkeryan
Copy link
Collaborator

bkeryan commented Jan 20, 2026

There are new sphinx and autoapi warnings that fail the doc checks for the ni.protobuf.types and ni.panels.v1.proto packages, something related to how the backing proto files import another proto and use its type as a member.

I cannot spend more time on this right now, so I'll suppress the warning and create an issue.

Update

image I will pin sphinx's major version. Such an upgrade doesn't seem like a valid use-case for 'lock file maintenance'

Agreed, lockFileMaintenance is mainly for indirect dependencies, but unfortunately it also upgrades direct dependencies and bypasses minimumReleaseAge.

Leaving lockFileMaintenance broken for a couple weeks would also be reasonable. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants