Various bug fixes and improvements by Wasupmacuz · Pull Request #78 · nicolai-wachenschwan/arc-overhang-prusaslicer-integration

Wasupmacuz · 2024-04-13T22:04:31Z

This branch of my fork primarily fixes #56 and fixes #77.

In the fix for Arcs not generated after removing bridge infill #77, I also included some code to create a failsafe if unusual geometry causes arc-generation to fail.
It also resolves Turning off the Hilbert Curve infill and random lines of filament. #66, as I've expanded the comment on specialCoolingZdist to explain how to disable Hilbert curves.
It may also sort out Little issues #47, regarding "Random Hibertcurve in the air" and "No arc at the middle overhang." That is, if "No arc at the middle overhang" was caused by Arcs not generated after removing bridge infill #77.
Additionally, it fixes some spelling and grammatical errors in the script header and removes trailing whitespace to decrease file size, albeit minimally.
Other minor changes outlined in commits.

Fixed the stringing due to travel moves occurring right before a feature change. Fixed the stringing travel moves included in the Hilbert curve polygons.

Moves the `modify` and `gcodeWasModified` booleans to the bottom of the loop, ensuring that if the polygon is discarded, we keep the old geometry. Makes the checks for if GCODE was modified more robust.

Adds a comment explaining how to disable special cooling, 68. Fixes bug where wipe moves cause invalid polygons, 445-455. Increased specificity for faster runtime, 531. Increased readability of conditional, 551.

Corrects some mild spelling and grammatical errors in the script header. Removes trailing space characters from the file (to shrink file size)

Wasupmacuz

Comments describing my changes.

Wasupmacuz · 2024-04-13T22:17:13Z

                            self.deleteTheseInfills.append(idp)
                            break
-                if self.parameters.get("PrintDebugVerification"):print(f"Layer {self.layernumber}: Poly{idp} is not close enough to overhang perimeters")        
+                    if self.parameters.get("PrintDebugVerification"):print(f"Layer {self.layernumber}: Poly{idp} is not close enough to overhang perimeters")


Changed indentation to print for every failed ohp instead of once every time after the loop.

Everything below this point is whitespace removal.

Wasupmacuz · 2024-04-13T22:19:28Z

        "applyAboveFanSpeedToWholeLayer":True,
        "CoolingSettingDetectionDistance":5, #if the gcode line is closer than this distance to an infill polygon the cooling settings will be applied. Unit:mm
-        "specialCoolingZdist":3, #use the special cooling XX mm above the arcs.
+        "specialCoolingZdist":3, #use the special cooling XX mm above the arcs. Set to a negative value to disable (not recommended).


Tells the user how to disable Hilbert curves. Could possibly stand to be more specific...

Wasupmacuz · 2024-04-13T22:22:16Z

                if layer.validpolys:
-                    modify=True
-                    gcodeWasModified=True
+                    numOverhangs += 1


We track the number of overhangs for error printing if arc generation fails. Not required, but could be useful.

Wasupmacuz · 2024-04-13T22:24:02Z

-                #apply special cooling settings:    
-                if len(layer.oldpolys)>0:
+                        modify=True
+                        gcodeWasModified=True


We moved these to the bottom of the loop so that they're only made true if arc generation was a success.

Wasupmacuz · 2024-04-13T22:37:06Z

+                    if self.lines[start - 1].startswith("G1 E") or not "E" in self.lines[start - 1]: # if a travel move came right before this feature:
+                        start -= 1
+                        while not "E" in self.lines[start - 1]: # include this travel move in the feature (excluding the first retraction step, if applicable)
+                            start -= 1


This is part of the fix for #56. Including the first retraction step also removes the stringing but gets rid of the retraction and de-retraction steps. Therefore, we leave out the first retraction step.

Wasupmacuz · 2024-04-13T22:39:55Z

        lines=self.features[idf-1][1]
        for line in reversed(lines):
-            if "G1" in line:
+            if line.startswith("G1 X"):


More clearly expresses our intent and runs marginally faster.

Wasupmacuz · 2024-04-13T22:40:23Z

                linesWithStart=linesWithStart+lines
                extPerimeterIsStarted=True
-            if (idf==len(self.features)-1 and extPerimeterIsStarted) or (extPerimeterIsStarted and not ("External" in ftype or "Overhang" in ftype)) :#finish the poly if end of featurelist or different feature
+            if extPerimeterIsStarted and (idf==len(self.features)-1 or not ("External" in ftype or "Overhang" in ftype)) :#finish the poly if end of featurelist or different feature


Shorter and more readable.

Wasupmacuz · 2024-04-13T22:42:37Z

                                parts.append(pts)
-                                pts=[]# update self.features... TODO
-                        elif "E" in line:     #maybe fix error of included travel moves? 
+                            pts=[]# update self.features... TODO


The other half of the fix for #56. This one removes the included travel moves in the Hilbert curves by always clearing single points when we travel.

Wasupmacuz · 2024-04-13T22:43:11Z

-                                pts=[]# update self.features... TODO
-                        elif "E" in line:     #maybe fix error of included travel moves? 
+                            pts=[]# update self.features... TODO
+                        elif "E" in line:     #maybe fix error of included travel moves?


Do we get rid of this comment now?

jperry004

Works well for me, I've been using the patch for a few days and generated many files with it. Reduces failed generation of certain geometries and reduces stringing. No regressions noticed for me.

Nathan22211 · 2024-08-28T13:48:10Z

did you try fixing #59 yet, or did that get patched already?

Wasupmacuz · 2024-11-24T18:51:18Z

did you try fixing #59 yet, or did that get patched already?

@Nathan22211 That must have been related to another issue because yes, this fixes #59.

Nathan22211 · 2024-11-30T19:17:01Z

nice, I'll have to see if it's easy enough to bring the fixed-up code into lousassole and Keilish's orca slicer fork of the script because orca is my main slicer

Wasupmacuz · 2024-11-30T19:21:41Z

nice, I'll have to see if it's easy enough to bring the fixed-up code into lousassole and Keilish's orca slicer fork of the script because orca is my main slicer

You may or may not want to wait for just a few minutes. I'm just about to finalize some changes to the script on my dev branch that fixes some outstanding bugs that I found while looking at this Kyogre. The script will also run faster 👍

Nathan22211 · 2024-12-09T22:52:01Z

yeah, I have no clue where to begin here... I've been looking at the function between lousassole's orca script and this and I have no clue what needs to be move into the orca script to bring your changes to work in orca slicer

Wasupmacuz · 2024-12-10T23:13:59Z

@Nathan22211 I'll take a crack at it when I get a moment. I was looking at that fork and saw many changes to Nic's code that would make it not so straightforward to combine the two.

Nathan22211 · 2024-12-14T01:09:24Z

yeah I actually can't get any Orca version script I find to work, they don't work for me it seems, also setuptools might need to be added to requirements because distutils was removed in 3.12

Wasupmacuz · 2025-03-23T04:48:40Z

@Nathan22211 Check out the latest patch on my fork. The script is now blazing fast, supports OrcaSlicer AND PrusaSlicer, has the ability to easily support any other slicer, and includes MANY new features.

Wasupmacuz added 4 commits April 11, 2024 12:34

Fixed Stringing

b46d7a4

Fixed the stringing due to travel moves occurring right before a feature change. Fixed the stringing travel moves included in the Hilbert curve polygons.

Fix skipping overhang leaving a hole.

b83d22b

Moves the `modify` and `gcodeWasModified` booleans to the bottom of the loop, ensuring that if the polygon is discarded, we keep the old geometry. Makes the checks for if GCODE was modified more robust.

Bug fix and improvements

f32833f

Adds a comment explaining how to disable special cooling, 68. Fixes bug where wipe moves cause invalid polygons, 445-455. Increased specificity for faster runtime, 531. Increased readability of conditional, 551.

Update header and remove extra whitespace

451d92e

Corrects some mild spelling and grammatical errors in the script header. Removes trailing space characters from the file (to shrink file size)

Wasupmacuz commented Apr 13, 2024

View reviewed changes

Wasupmacuz marked this pull request as ready for review April 13, 2024 22:47

jperry004 approved these changes Apr 16, 2024

View reviewed changes

Conversation

Wasupmacuz commented Apr 13, 2024

This branch of my fork primarily fixes #56 and fixes #77.

Uh oh!

Wasupmacuz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jperry004 left a comment

Choose a reason for hiding this comment

Uh oh!

Nathan22211 commented Aug 28, 2024

Uh oh!

Wasupmacuz commented Nov 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nathan22211 commented Nov 30, 2024

Uh oh!

Wasupmacuz commented Nov 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nathan22211 commented Dec 9, 2024

Uh oh!

Wasupmacuz commented Dec 10, 2024

Uh oh!

Nathan22211 commented Dec 14, 2024

Uh oh!

Wasupmacuz commented Mar 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Wasupmacuz commented Nov 24, 2024 •

edited

Loading

Wasupmacuz commented Nov 30, 2024 •

edited

Loading