Implement #1687 - Add %{all} format variables to lists queries#1708
Open
BenjaminBini wants to merge 2 commits intonikitabobko:mainfrom
Open
Implement #1687 - Add %{all} format variables to lists queries#1708BenjaminBini wants to merge 2 commits intonikitabobko:mainfrom
BenjaminBini wants to merge 2 commits intonikitabobko:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the %{all} format variable for Aerospace list commands, allowing users to include all available variables in output when using the --json flag. This addresses issue #1687.
- Adds
%{all}format variable support to all list commands (windows, workspaces, apps, monitors) - Implements validation to ensure
%{all}is only used with--jsonflag and cannot be mixed with other variables - Updates documentation and adds comprehensive test coverage
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/aerospace-list-*.adoc | Documents the new %{all} format variable for all list commands |
| Sources/Common/cmdArgs/impl/ListWindowsCmdArgs.swift | Adds %{all} enum case, validation logic, and format handling |
| Sources/Common/cmdArgs/impl/ListWorkspacesCmdArgs.swift | Updates format handling and adds validation for %{all} usage |
| Sources/Common/cmdArgs/impl/ListMonitorsCmdArgs.swift | Updates format handling and adds validation for %{all} usage |
| Sources/Common/cmdArgs/impl/ListAppsCmdArgs.swift | Updates format handling and adds validation for %{all} usage |
| Sources/AppBundleTests/command/*.swift | Adds test coverage for %{all} format variable validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nikitabobko
force-pushed
the
main
branch
2 times, most recently
from
f324d2e to
7aff813
Compare
…ries
Add %{all} format variable support to commands listing Aerospace objects :
* `list-windows`
* `list-workspaces`
* `list-apps`
* `list-monitors`
Convenient way to output all available format variables in list queries rather than listing all of them.
Following variables are ignored from the output: `rightPadding`, `newLine`, `tab`.
It only works when using JSON format (--json argument).
Variable can not be used with other variables in the template string, it must be alone (whitespaces ignored).
BenjaminBini
force-pushed
the
issue-1687
branch
from
8083330 to
1a4b997
Compare
Author
|
Rebased on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add %{all} format variable support to commands listing Aerospace objects :
list-windowslist-workspaceslist-appslist-monitorsIncludes relevant tests and doc.
More details in commit description.