[Feature] Alias for combinations (#224)#1723
Open
lheiskan wants to merge 1 commit intonikitabobko:mainfrom
Open
[Feature] Alias for combinations (#224)#1723lheiskan wants to merge 1 commit intonikitabobko:mainfrom
lheiskan wants to merge 1 commit intonikitabobko:mainfrom
Conversation
Extends `[key-mapping.key-notation-to-key-code]` to support defining aliases for modifier combinations (e.g., hyper key). Example config: ```toml [key-mapping.key-notation-to-key-code] hyper = 'ctrl-alt-shift-cmd' [mode.main.binding] hyper-c = 'workspace c' ``` Mixing modifiers and keys in a single alias is not supported. Invalid combinations are checked and result in configuration error messages. Change introduces `KeyOrModifier` enum to represent either single keys or modifier combinations. Implements: nikitabobko#224 Related: nikitabobko#389 Related: nikitabobko#1223
f324d2e to
7aff813
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Owner
|
I didn't yet have time to review this PR. But just wanted to mention that this PR has heavy merge conflicts with another PR: #1714 The mentioned PR is more important and will be reviewed/merged first. If the conflicts are trivial, I will resolve them myself. Otherwise, this PR might require more adjustments in the future |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Author
Davincible
added a commit
to Davincible/AeroSpace
that referenced
this pull request
Feb 11, 2026
# Conflicts: # Sources/AppBundle/config/Mode.swift # Sources/AppBundle/config/parseKeyMapping.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
[key-mapping.key-notation-to-key-code]to support defining aliases for modifier combinations (e.g., hyper key).Example config:
Mixing modifiers and keys in a single alias is not supported. Invalid combinations are checked and result in configuration error messages.
Change introduces
KeyOrModifierenum to represent either single keys or modifier combinations.Implements: #224
Related: #389
Related: #1223
PR checklist
Failure to follow the checklist with no apparent reasons will result in silent PR rejection.