Skip to content

wanted to make a valuable addition to your project#3

Open
Fappp wants to merge 3 commits intoniksudan:masterfrom
Fappp:patch-1
Open

wanted to make a valuable addition to your project#3
Fappp wants to merge 3 commits intoniksudan:masterfrom
Fappp:patch-1

Conversation

@Fappp
Copy link
Copy Markdown

@Fappp Fappp commented Jun 3, 2016

No description provided.

Copy link
Copy Markdown
Owner

@niksudan niksudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not good enough. Sorry it took almost a year, was tough to review.

Comment thread package.json Outdated
"homepage": "https://github.com/niksudan/butt#readme"
}

//I am coder now
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come on dude, putting a space after // is all the range these days

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace slows down applications tremendously, I'd like to advice removing it all from the code.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry Dave, I can't do that.

@niksudan
Copy link
Copy Markdown
Owner

niksudan commented Oct 4, 2017

Any updates on this? This is quite a heavily requested feature.

@Fappp
Copy link
Copy Markdown
Author

Fappp commented Jan 3, 2018

It is done

Copy link
Copy Markdown
Owner

@niksudan niksudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks! But we're not there just yet.

Comment thread package.json Outdated
}

// I am coder now
//EDIT 3-1-2018, Added a space after the comment above on request. Styling is important!
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use YYYY-MM-DD format for timestamps?

Copy link
Copy Markdown
Owner

@niksudan niksudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work so far! I can see the light at the end of the tunnel!

Comment thread package.json Outdated
},
"homepage": "https://github.com/niksudan/butt#readme"
}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this new line at the end of this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants