Added some more fuzzers in to the source#3003
Open
personnumber3377 wants to merge 1 commit intonimiq:albatrossfrom
Open
Added some more fuzzers in to the source#3003personnumber3377 wants to merge 1 commit intonimiq:albatrossfrom
personnumber3377 wants to merge 1 commit intonimiq:albatrossfrom
Conversation
Eligioo
reviewed
Oct 31, 2024
fuzz/Cargo.toml
Outdated
| nimiq-primitives = { workspace = true, features = ["key-nibbles", "serde-derive", "trie"] } | ||
| nimiq-serde = { workspace = true } | ||
| nimiq-bls = { workspace = true } | ||
| nimiq-keys = { workspace = true } |
Member
There was a problem hiding this comment.
Usually we try to keep dependency names in alphabetical order
fuzz/src/bin/staking_contract.rs
Outdated
| use nimiq_account::StakingContract; | ||
| let res = StakingContract::deserialize_from_vec(data); // err I think is of type DeserializeError | ||
|
|
||
| // Now check if contr exists. If it does (aka. the original data was a valid staking contract) then try to serialize it back to a vector, then check if the original vector and the new vector are the same, if they aren't then there is a bug in the parsing logic. |
Member
There was a problem hiding this comment.
Suggested change
| // Now check if contr exists. If it does (aka. the original data was a valid staking contract) then try to serialize it back to a vector, then check if the original vector and the new vector are the same, if they aren't then there is a bug in the parsing logic. | |
| // Now check if contract exists. If it does (aka. the original data was a valid staking contract) then try to serialize it back to a vector, then check if the original vector and the new vector are the same, if they aren't then there is a bug in the parsing logic. |
fuzz/src/bin/staking_contract.rs
Outdated
|
|
||
| // Now check if contr exists. If it does (aka. the original data was a valid staking contract) then try to serialize it back to a vector, then check if the original vector and the new vector are the same, if they aren't then there is a bug in the parsing logic. | ||
|
|
||
| // The existance of error implies that contr does not exist. |
Member
There was a problem hiding this comment.
Suggested change
| // The existance of error implies that contr does not exist. | |
| // The existence of error implies that contract does not exist. |
fuzz/src/bin/staking_contract.rs
Outdated
|
|
||
| // arg[..30].try_into().unwrap() | ||
|
|
||
| let bullshit: &[u8] = data[..(otherdata.len())].try_into().unwrap(); // Yuck!!! |
Member
There was a problem hiding this comment.
Please use a proper name for the variable 😉
fuzz/src/bin/staking_contract.rs
Outdated
| if (err == None) { | ||
| // Contr exists | ||
| assert!(contr, "contr didn't exist, even though err == None!!!!"); // Debug. | ||
| // Now try to serialize to vec |
Member
There was a problem hiding this comment.
Please clean up the code in general. Redundant/commented code, test sections, etc.
Member
|
Can you squash the commits? |
Author
Author
|
Hi! I cleaned up the code in this commit: 3f13e9e . |
Member
You can squash them through |
Member
|
Squashed commits and rebased branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This pull request adds some more fuzzers to the codebase.
Pull request checklist
clippyandrustfmtwarnings.