Fix typo in client.py & Added query=None, fid=None parameters to client.open#550
Open
Torndeco wants to merge 6 commits intonithinmurali:stagingfrom
Open
Fix typo in client.py & Added query=None, fid=None parameters to client.open#550Torndeco wants to merge 6 commits intonithinmurali:stagingfrom
Torndeco wants to merge 6 commits intonithinmurali:stagingfrom
Conversation
Minor change to allow passing a query when opening a spreadsheet i.e query='trashed=false' To avoid opening spreadsheet that is is trashed
Update param doc
Typo Fix
Typo Fix
Added query=None, fid=None parameters to client.open
Owner
|
Thank you for the PR! |
Owner
|
I am concerned about removing the index access from here. It looks like that function returns a list hence index access is necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added query so can filter out opening spreadsheets that are trashed 'trashed=false', also added open to open via file id