ActiveWindow: per-screen focus tracking (sway) & instant updates#1783
Open
yorickvP wants to merge 3 commits intonoctalia-dev:mainfrom
Open
ActiveWindow: per-screen focus tracking (sway) & instant updates#1783yorickvP wants to merge 3 commits intonoctalia-dev:mainfrom
yorickvP wants to merge 3 commits intonoctalia-dev:mainfrom
Conversation
Replace the debounce timer with direct calls: onActiveToplevelChanged now invokes safeUpdateWindows()+activeWindowChanged() immediately, a new onTitleChanged handler keeps titles current, and onRawEvent filters by event type so workspace/window queries only run when relevant.
Stop looking up a fallback icon when nothing is focused: return an empty string instead of ThemeIcons.iconFromName(fallbackIcon) so the icon provider does not log warnings for the "user-desktop" name.
Add per-output focus map so each bar instance shows the window last focused on its own screen, with live title reads for unfocused outputs. Includes stale-handle validation, empty-workspace sync via the tree query, a per-screen toggle in widget settings, and the default enabled in BarWidgetRegistry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Motivation
This PR changes the ActiveWindow widget, mainly on sway, to:
Type of Change
Mark the relevant option with an "x".
Testing
Describe how you tested your changes and mark the relevant items.
Screenshots / Videos
If applicable, include screenshots or videos to help illustrate your changes.
Checklist
Additional Notes