Append noctalia.css import to the end of gtk-4.0/gtk.css instead of overwriting it#1784
Open
finsofblueimnotyou wants to merge 1 commit intonoctalia-dev:mainfrom
Open
Append noctalia.css import to the end of gtk-4.0/gtk.css instead of overwriting it#1784finsofblueimnotyou wants to merge 1 commit intonoctalia-dev:mainfrom
finsofblueimnotyou wants to merge 1 commit intonoctalia-dev:mainfrom
Conversation
Contributor
|
I think you forgotten apply_gtk3 |
Collaborator
|
Heyo @finsofblueimnotyou , we split gtk into gtk3 & gtk4 not too long ago, if you'd like to manage that, I'd be all for merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Motivation
As it currently stands, the GTK color scheme template overwrites the contents of
~/.config/gtk-4.0/gtk.csswith@import url("noctalia.css");. This has the adverse effect of wiping any user-made modifications to the file.This request addresses the issue by having the
noctalia.cssimport appended to the end ofgtk.css, rather than overwriting it. This new behavior is similar to that of the niri template. If the import is already present, nothing is written, and if the file doesn't exist, it is made with the import as per the previous functionality.Type of Change
Mark the relevant option with an "x".
Related Issue
Testing
Tested with the following permutations:
gtk.cssnot present.gtk.csspresent with no content.gtk.csspresent with user-made modifications.gtk.csspresent withnoctalia.cssimport.gtk.csspresent with user-made modifications andnoctalia.cssimport.Tested on niri
Tested on Hyprland
Tested on sway
Tested with different bar positions and density settings
Tested at different interface scaling values
Tested with multiple monitors (if applicable)
Screenshots / Videos
N/A
Checklist
Additional Notes
This is my first pull request, please let me know if I did anything wrong!