Skip to content

feat(theming): add qimgv template#2002

Open
HANDZCZ wants to merge 1 commit intonoctalia-dev:mainfrom
HANDZCZ:add-qimgv-template
Open

feat(theming): add qimgv template#2002
HANDZCZ wants to merge 1 commit intonoctalia-dev:mainfrom
HANDZCZ:add-qimgv-template

Conversation

@HANDZCZ
Copy link
Contributor

@HANDZCZ HANDZCZ commented Feb 28, 2026

Pull Request

Motivation

Adds theme template for qimgv.

Type of Change

Mark the relevant option with an "x".

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring

Related Issue

Testing

Tested with multiple predefined color schemes.

  • Tested on niri
  • Tested on Hyprland
  • Tested on sway
  • Tested with different bar positions and density settings
  • Tested at different interface scaling values
  • Tested with multiple monitors (if applicable)

Screenshots / Videos

Screenshot from 2026-02-28 21-14-57 Screenshot from 2026-02-28 21-21-38

Checklist

  • Code follows project style guidelines
  • Self-reviewed my code
  • No new warnings or errors
  • Documentation or comments updated (if relevant)

Additional Notes

If you can, please check that the theme looks somewhat decent and is similar to other apps.
Also, I couldn't find anything about hot-reloading the theme, so it only updates when relaunching the app.

@ItsLemmy
Copy link
Collaborator

ItsLemmy commented Mar 1, 2026

This seems to be Qt app, how was it looking without a custom template? In theory it should follow Qt theming.
We only want to offer the common apps as built int templates the other more niche one should be user-templates to avoid cluttering the UI and codebase.

@HANDZCZ
Copy link
Contributor Author

HANDZCZ commented Mar 1, 2026

This is on Eldritch color scheme when "use system colors" is on:

Scroll level is not visible, has wrong text color and background color:
image

Background is inconsistent, black when viewing the picture, and the right color when browsing folders, outline for the popups is missing (wrong color):
image
Forgot to add how it looks when themed...
image

Folders have this whiteish color, which is really bright on a dark theme:
image

@ItsLemmy
Copy link
Collaborator

ItsLemmy commented Mar 1, 2026

have you tried to see if this was fixable on the main Qt template ?

@HANDZCZ
Copy link
Contributor Author

HANDZCZ commented Mar 1, 2026

I can try, but I thought that the Qt template was "final" and qimgv is using it wrong.

Ok, I just looked, and qimgv is not even setting the background color or overlay text/background color, so it is 0x000000.
It uses the same color for the popup and its border.
Here is the color definition part: https://github.com/easymodo/qimgv/blob/master/qimgv/themestore.cpp#L9-L18
Basically, the entire "use system theme" option is almost unusable for actual theming.

It also doesn't help that I can't find the format for the Qt ColorScheme option and any Qt color scheme testing app.
So I can't even fix qimgv and the Qt template (if needed).

@ItsLemmy
Copy link
Collaborator

ItsLemmy commented Mar 2, 2026

It's most likely true: qimgv does not use Qt colors as it should, and they should fix it. Maybe open a bug report there.

I recommend you keep this as a user template for now, which work just fine.
Unless there is a ton of traction for that PR, I do not plan to merge this as it's a pretty small app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants