Studio2/SD/API: Exclude more static_kwargs in StableDiffusion.init for now#2096
Open
one-lithe-rune wants to merge 1 commit intonod-ai:sd-studio2from
Open
Studio2/SD/API: Exclude more static_kwargs in StableDiffusion.init for now#2096one-lithe-rune wants to merge 1 commit intonod-ai:sd-studio2from
one-lithe-rune wants to merge 1 commit intonod-ai:sd-studio2from
Conversation
- Comment out precision being set in static_kwargs for vae_encode when setting up a StableDiffusion pipeline - Comment out precision being set in static_kwargs for vae_decode when setting up a StableDiffusion pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Although the changes in #2091 got things to failing at the point of
iree-compileof unet for me, the merged version considers vae_encode before unet. It turns out vae_encode has a similar problem with including aprecisionargument when main branchturbine_models.custom_models.sd_inferencedoesn't yet include it.This comments out
precisionfor all the blocks in the thestatic_kwargsvariable which defines how the the various pipeline models are called, and gets us back to aniree-compilefailure again.Changes
Possible Problems/Concerns
precisionis landed in the Turbine models, I've added a TODO comment saying that.