Refactor node implementor for reuse #22
Merged
+98
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
force-pushed
the
node-implementor-refactor
branch
from
566435d to
7a9add1
Compare
kraenhansen
force-pushed
the
node-implementor-refactor
branch
from
7a9add1 to
b0720ac
Compare
legendecas
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for a Bun and Deno implementor, I see an opportunity to reuse the function to list directory entries (if turned synchronous) and running a test file in a sub-process (as both Bun and Deno implement this part of the Node.js runtime APIs). For that to work, I need to move the functions into a separate file to allow imports without invoking the
node:testAPIs.