fix: Handle FormData body type correctly in RetryAgent retried requests #4692
+73
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
approved these changes
Dec 9, 2025
Author
|
@mcollina @metcoder95 Is there anything I need to do to keep this PR moving? |
mcollina
approved these changes
Jan 5, 2026
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
lgtm
nothing, landing as CI is green
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4692 +/- ##
=======================================
Coverage 92.87% 92.87%
=======================================
Files 109 109
Lines 33826 33828 +2
=======================================
+ Hits 31415 31419 +4
+ Misses 2411 2409 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Can you rebase with |
eliotschu
force-pushed
the
fix--retryagent-formdata
branch
from
ab54034 to
66d1508
Compare
Author
|
@metcoder95 For sure, it should be up to date now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
When a RetryAgent request has FormData body, currently since FormData passes
(body && typeof body !== 'string' && !ArrayBuffer.isView(body) && isIterable(body))it gets converted to BodyAsyncIterable which leads to extractBody() never being called on retried requests. Now FormData body is checked for and returned without manipulation.Changes
Add a new check on the body using the existing isFormDataLike() utility function. Add a new unit test that references the issue number and runs the retry agent with FormData body.
Features
Bug Fixes
Breaking Changes and Deprecations
Status