feat(axios-to-whatwg-fetch): introduce
#269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustinMauroy
added
the
awaiting reviewer
AugustinMauroy
removed
the
awaiting reviewer
Member
|
omg please yes |
Member
Author
|
cc @nodejs/userland-migrations can I have first review on this one |
AugustinMauroy
added
the
awaiting reviewer
brunocroh
approved these changes
Dec 13, 2025
Member
brunocroh
left a comment
brunocroh
left a comment
There was a problem hiding this comment.
I just identified one point that could be simplified, but nothing major.
Co-Authored-By: Bruno Rodrigues <[email protected]>
brunocroh
approved these changes
Dec 13, 2025
AugustinMauroy
commented
Dec 15, 2025
|
|
||
| let currentEol = '\n'; | ||
|
|
||
| const detectEol = (source: string) => (source.includes('\r\n') ? '\r\n' : '\n'); |
Member
Author
There was a problem hiding this comment.
I'm not fan of that but idk what should I do to make windows pass
Member
There was a problem hiding this comment.
Maybe we can try enable --ignore-whitespaces on windows pipeline?
brunocroh
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
close #191
Missing part