feat(outgoingmessage-headers) #281
Conversation
|
No need to ping me, I receive notification for all thing on the repo |
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
Not too bad there are some pont that you can improve 👍
| const matches = rootNode.findAll({ | ||
| rule: { pattern: "$OBJ._headers[$KEY]" }, | ||
| }); | ||
| for (const m of matches) { |
There was a problem hiding this comment.
| for (const m of matches) { | |
| for (const m of matches) { |
|
|
||
| { | ||
| const matches = rootNode.findAll({ | ||
| rule: { pattern: "$OBJ._headers[$KEY]" }, |
There was a problem hiding this comment.
main part here...
Here if the user code have ah propriety expression _headers it's will be catch. We need a more complex logic to catch http usage and -> catch response objects -> catch _headers
I have to admit that the orignal issue examples wasn't 100% complete
|
bump @elvessilvavieira 👋 |
AugustinMauroy
added
the
awaiting author
elvessilvavieira
force-pushed
the
feat(outgoingmessage-headers)
branch
from
259f795 to
06a18ea
Compare
|
Hi, Augustin I renamed the folder to http-outgoing message-headers then created a function looksLikeOutgoingMessage. pls tell me if it's weak in preventing false positives, or if there are any utilities that could help me. I even considered using resolveBindingPath for when they explicitly use http.createServer, but it has some drawbacks |
Yeah to have better handling of the detection/node catch workflow we can use https://docs.codemod.com/jssg/semantic-analysis which is a brand new feature of codemod BTW codemod have a mcp that can help you it's aware of this new feature |
2 participants
Hi, @AugustinMauroy
Here's a draft. I'd like to know if I'm on the right track. There are some things missing, like the README, but I'll add them. Thx
issue: #128