🧪 fix: resolve typecheck, lint, and test failures#768
Open
claude[bot] wants to merge 1 commit intomainfrom
Open
🧪 fix: resolve typecheck, lint, and test failures#768claude[bot] wants to merge 1 commit intomainfrom
claude[bot] wants to merge 1 commit intomainfrom
Conversation
- Fix typecheck error in provider_handler.py: use "image_url" instead of "image" for MessageImageContent - Fix 41 lint errors with ruff auto-fixes and 3 manual fixes - Fix test failures: implement missing search_raw abstract method in ApifyProvider and DataForSEOProvider - All validation commands now pass: make typecheck, make lint, make test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all validation failures identified during scheduled quality assurance run.
Changes Made
Typecheck Error Fix (
src/nodetool/worker/provider_handler.py)MessageImageContentexpectstype="image_url"but code was usingtype="image"type="image"totype="image_url"to match the type definitionLint Errors Fixed (41 total → 0)
ruff --fix(import sorting, unnecessary mode arguments, whitespace)tests/test_parity_snapshot_export.pytests/worker/test_context_stub.pynext(iter())instead of single-element sliceTest Failures Fixed (8 failed, 4 errors → 0)
search_raw()abstract method inApifyProvidersearch_raw()abstract method inDataForSEOProviderTest Results
make typecheck: All checks passedmake lint: All checks passedmake test: 4129 passed, 115 skippedFiles Changed
src/nodetool/worker/provider_handler.py- Typecheck fixsrc/nodetool/agents/serp_providers/apify_provider.py- Added search_raw methodsrc/nodetool/agents/serp_providers/data_for_seo_provider.py- Added search_raw methodsrc/nodetool/providers/huggingface_provider.py- Whitespace fixes🤖 Generated with Claude Code