✨ feat(metadata): implement type checking for ComfyUI types#770
Open
claude[bot] wants to merge 1 commit intomainfrom
Open
✨ feat(metadata): implement type checking for ComfyUI types#770claude[bot] wants to merge 1 commit intomainfrom
claude[bot] wants to merge 1 commit intomainfrom
Conversation
Implements proper type validation for ComfyUI types in the is_assignable function. Previously, all ComfyUI types were treated as universally assignable, which bypassed type safety checks. The new implementation validates that: - Dict values have a matching 'type' field - Object instances have a matching 'type' attribute - Values without type information are rejected This improves type safety for ComfyUI workflows by ensuring only compatible types are assignable during workflow validation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements proper type validation for ComfyUI types (types starting with "comfy.") in the
is_assignablefunction. Previously, all ComfyUI types were treated as universally assignable, which bypassed type safety checks and could lead to runtime errors.Changes
src/nodetool/metadata/typecheck.py: Implemented type field validation for ComfyUI typesvalue.get("type") == type_meta.typevalue.type == type_meta.typeFalsetests/metadata/test_typecheck.py: Updated test to reflect new behavior.github/opencode-memory/features.md: Added feature documentationTest plan
🤖 Generated with Claude Code