✨ feat(models): implement external payload storage for RunInboxMessage#772
Open
claude[bot] wants to merge 1 commit intomainfrom
Open
✨ feat(models): implement external payload storage for RunInboxMessage#772claude[bot] wants to merge 1 commit intomainfrom
claude[bot] wants to merge 1 commit intomainfrom
Conversation
Implement the TODO comment at line 348 to support loading large message payloads from external storage. The payload_ref field already existed in the data model but loading logic was not implemented. Changes: - Make get_payload() async to support external storage loading - Add imports for json, io, and maybe_scope - Implement external payload loading using ResourceScope.get_temp_storage() - Add proper error handling for missing ResourceScope or storage - Update test to use await msg1.get_payload() - Add tests for external payload storage functionality - Update features.md to document the new feature Files: - src/nodetool/models/run_inbox_message.py - tests/workflows/test_state_tables_refactor.py - .github/opencode-memory/features.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements external payload storage for
RunInboxMessageto support large message payloads without database bloat. Thepayload_reffield already existed in the data model but loading logic was not implemented (TODO comment at line 348).Changes
src/nodetool/models/run_inbox_message.py:get_payload()async to support external storage loadingjson,io, andmaybe_scopeResourceScope.get_temp_storage()tests/workflows/test_state_tables_refactor.py:await msg1.get_payload()test_external_payload_storage()to test external storage loadingtest_external_payload_no_scope_error()to test error handling.github/opencode-memory/features.md:Test Plan
TestRunInboxMessagepassedBenefits
get_payload()method🤖 Generated with Claude Code